[Benchmarks] Fix sycl preview double runs #20129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
ianayl
reviewed
Sep 18, 2025
| GraphApiFinalizeGraph(self, RUNTIMES.SYCL, 1, "Llama"), | ||
| ] | ||
| for profiler_type in profiler_types: | ||
| for measure_cpu in [0, 1]: |
There was a problem hiding this comment.
Can I ask why we're changing from profiler_type to a boolean for measure_cpu? Are we not expecting to have more profiler types in the future?
There was a problem hiding this comment.
I've tried to make changes cleaner. Created an enum instead. This brings both clarity and extensibility to this code (hopefully).
|
This is a lot cleaner than before! Changes look good, but I will wait for test runs first before approving. |
PatKamin
force-pushed
the
fix-sycl-preview-dashboard
branch
from
4fc63ff to
d49f9d0
Compare
PatKamin
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
PatKamin
force-pushed
the
fix-sycl-preview-dashboard
branch
from
d49f9d0 to
dfb4e99
Compare
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Prevent syclpreview benchmarks scenarios from running twice.
ianayl
approved these changes
Sep 23, 2025
|
@intel/llvm-gatekeepers PR should be good, thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix syclpreview benchmarks running twice for each scenario.